Skip to content

Conversation

waynzh
Copy link
Member

@waynzh waynzh commented Nov 3, 2024

resolve #2564
Add support for automatically deleting empty blocks.

Chose this approach is because I couldn't find a better way to handle reporting & fixing each emptyBlock within a for loop, as removing the first block will affect the range of the second block😵‍💫.
UPDATE: Due to lack of whitespaces in test cases.

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR!

@waynzh waynzh requested a review from ota-meshi November 11, 2024 08:23
waynzh and others added 2 commits November 11, 2024 17:16
Co-authored-by: Flo Edelmann <git@flo-edelmann.de>
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@waynzh waynzh changed the title feat(no-empty-component-block): add autofix option feat(no-empty-component-block): support auto fix Nov 11, 2024
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now. Thanks @waynzh!

@FloEdelmann FloEdelmann merged commit b779f88 into vuejs:master Nov 11, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants