Skip to content

fix(require-explicit-slots): ignore attribute binding #2591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 11, 2024
Merged

fix(require-explicit-slots): ignore attribute binding #2591

merged 5 commits into from
Nov 11, 2024

Conversation

waynzh
Copy link
Member

@waynzh waynzh commented Nov 2, 2024 •
edited
Loading

fixes #2589.

Previously: When node.directive was true, slotName was incorrectly set to 'default', and it would check if it was explicitly defined.
Now: If node.directive is true and is not string literal, the report is simply skipped.
FloEdelmann
FloEdelmann reviewed Nov 4, 2024
View reviewed changes
FloEdelmann
FloEdelmann approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I only have one more minor comment.
@FloEdelmann FloEdelmann requested a review from ota-meshi November 6, 2024 10:56
ota-meshi
ota-meshi approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you very much for your contributions!
@ota-meshi ota-meshi merged commit e13089e into vuejs:master Nov 11, 2024
18 checks passed
@waynzh waynzh deleted the fix/ignore-attribute-binding branch November 11, 2024 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@waynzh @FloEdelmann @ota-meshi