Fix detect Nuxt3 defineNuxtComponent #2311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
2 tasks
FloEdelmann reviewed Nov 14, 2023
FloEdelmann reviewed Nov 14, 2023
| @FloEdelmann |
FloEdelmann approved these changes Nov 14, 2023
There was a problem hiding this comment.
LGTM 🙂
@ota-meshi Should we consider this a breaking change and keep this for v10? (see #2166)
ota-meshi approved these changes Nov 29, 2023
Yeah. I think this should be included in v10. |
Closed
FloEdelmann pushed a commit that referenced this pull request Nov 27, 2024
ota-meshi pushed a commit that referenced this pull request Nov 30, 2024
FloEdelmann pushed a commit that referenced this pull request Dec 13, 2024
FloEdelmann pushed a commit that referenced this pull request Dec 16, 2024
FloEdelmann pushed a commit that referenced this pull request Dec 19, 2024
FloEdelmann pushed a commit that referenced this pull request Jan 3, 2025
FloEdelmann pushed a commit that referenced this pull request Jan 22, 2025
FloEdelmann pushed a commit that referenced this pull request Jan 29, 2025
FloEdelmann pushed a commit that referenced this pull request Feb 12, 2025
FloEdelmann pushed a commit that referenced this pull request Feb 12, 2025
waynzh pushed a commit that referenced this pull request Feb 20, 2025
ota-meshi pushed a commit that referenced this pull request Mar 5, 2025
ota-meshi pushed a commit that referenced this pull request Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
vue/no-unused-propertiesdoes not work withdefineNuxtComponent()#2191vue/order-in-componentsis not working withdefineNuxtComponent()#2057Description
It's just a workaround like solution.
Add the
defineNuxtComponentalias for Nuxt3 projects, similar to #1088.About defineNuxtComponent
The difference between
defineNuxtComponentanddefineComponentis onlyasyncDataandheadoptions are added ondefineNuxtComponent.These options are not essential to check in vue-eslint-plugin, so it should be fine to treat it as
defineComponent.https://nuxt.com/docs/api/utils/define-nuxt-component