Skip to content

Conversation

@hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Nov 24, 2024

Description

So, what's happened is that @babel/plugin-syntax-import-attributes was necessary until quite recently, but it's now included in babel core since 7.26 https://babeljs.io/blog/2024/10/25/7.26.0#import-attributes-16579. Previously users would've seen more direct error message instead:

Add @babel/plugin-syntax-import-attributes (https://github.com/babel/babel/tree/main/packages/babel-plugin-syntax-import-attributes) to the 'plugins' section of your Babel config to enable parsing.

This monorepo had 7.25, so I actually got this error. For now, I updated @babel/core to make it work. I'll review pending renovate PR #373 since that includes @babel/core update too.

For user with version < 7.26, I assume generatorOpts.importAttributesKeyword would be no-op, so probably it's fine to always add it on our side.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
@hi-ogawa hi-ogawa marked this pull request as ready for review November 24, 2024 02:30
@ArnaudBarre ArnaudBarre merged commit 5d2b6c6 into main Nov 26, 2024
13 checks passed
@ArnaudBarre ArnaudBarre deleted the fix-force-import-attributes-with branch November 26, 2024 10:29
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Nov 27, 2024
| datasource | package | from | to | | ---------- | -------------------- | ----- | ----- | | npm | @vitejs/plugin-react | 4.3.3 | 4.3.4 | ## [v4.3.4](https://github.com/vitejs/vite-plugin-react/blob/HEAD/packages/plugin-react/CHANGELOG.md#434-2024-11-26) ##### Add Vite 6 to peerDependencies range Vite 6 is highly backward compatible, not much to add! ##### Force Babel to output spec compliant import attributes [#386](vitejs/vite-plugin-react#386) The default was an old spec (`with type: "json"`). We now enforce spec compliant (`with { type: "json" }`)
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Nov 28, 2024
| datasource | package | from | to | | ---------- | -------------------- | ----- | ----- | | npm | @vitejs/plugin-react | 4.3.3 | 4.3.4 | ## [v4.3.4](https://github.com/vitejs/vite-plugin-react/blob/HEAD/packages/plugin-react/CHANGELOG.md#434-2024-11-26) ##### Add Vite 6 to peerDependencies range Vite 6 is highly backward compatible, not much to add! ##### Force Babel to output spec compliant import attributes [#386](vitejs/vite-plugin-react#386) The default was an old spec (`with type: "json"`). We now enforce spec compliant (`with { type: "json" }`)
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Nov 29, 2024
| datasource | package | from | to | | ---------- | -------------------- | ----- | ----- | | npm | @vitejs/plugin-react | 4.3.3 | 4.3.4 | ## [v4.3.4](https://github.com/vitejs/vite-plugin-react/blob/HEAD/packages/plugin-react/CHANGELOG.md#434-2024-11-26) ##### Add Vite 6 to peerDependencies range Vite 6 is highly backward compatible, not much to add! ##### Force Babel to output spec compliant import attributes [#386](vitejs/vite-plugin-react#386) The default was an old spec (`with type: "json"`). We now enforce spec compliant (`with { type: "json" }`)
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Nov 30, 2024
| datasource | package | from | to | | ---------- | -------------------- | ----- | ----- | | npm | @vitejs/plugin-react | 4.3.3 | 4.3.4 | ## [v4.3.4](https://github.com/vitejs/vite-plugin-react/blob/HEAD/packages/plugin-react/CHANGELOG.md#434-2024-11-26) ##### Add Vite 6 to peerDependencies range Vite 6 is highly backward compatible, not much to add! ##### Force Babel to output spec compliant import attributes [#386](vitejs/vite-plugin-react#386) The default was an old spec (`with type: "json"`). We now enforce spec compliant (`with { type: "json" }`)
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Dec 1, 2024
| datasource | package | from | to | | ---------- | -------------------- | ----- | ----- | | npm | @vitejs/plugin-react | 4.3.3 | 4.3.4 | ## [v4.3.4](https://github.com/vitejs/vite-plugin-react/blob/HEAD/packages/plugin-react/CHANGELOG.md#434-2024-11-26) ##### Add Vite 6 to peerDependencies range Vite 6 is highly backward compatible, not much to add! ##### Force Babel to output spec compliant import attributes [#386](vitejs/vite-plugin-react#386) The default was an old spec (`with type: "json"`). We now enforce spec compliant (`with { type: "json" }`)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants