feat: introduce wrapperDiv option #61
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR adds a boolean option
wrapperDivthat makes the wrapper div optional in a way that doesn't break the existing API.I can see the value of the wrapper div in some situations but don't see a reason for it to be required.
And when a
wrapperComponentis specified the extra div feels especially unnecessary and gets in the way.Making it optional allows for cleaner simpler markup and makes, for example, styling easier.
Apologies - I made the PR before discussing but let me know what you think / if it is mergable (or not)
Also, just to say, thanks for a great plugin!!