feat: Added option to convert internal links to router links #38
Conversation
|
|
| | ||
| const scriptSetupRE = /<\s*script([^>]*)\bsetup\b([^>]*)>([\s\S]*)<\/script>/mg | ||
| const defineExposeRE = /defineExpose\s*\(/mg | ||
| const internalLinkRE = /\[(.+)\]\((\/[?=\w\/-]*)\)/g |
There was a problem hiding this comment.
I am worried that this regex can lead to some false passive. Could we do it with a markdown it plugin?
There was a problem hiding this comment.
Sure. Any you recommend? If not, I'll look around for a plugin.
There was a problem hiding this comment.
You're right about this regex. It captured images  and it isn't correctly capturing links that are in the same line. I will flesh it out some more and push to this PR. Haven't found an obvious plugin to use just yet.
There was a problem hiding this comment.
See the links plugin in VuePress: https://github.com/vuepress/core/blob/main/packages/markdown/src/plugins/linksPlugin/linksPlugin.ts
Notice that VitePress does not use vue-router at all, so it does not have RouterLink transformation. Just put its plugin here as a reference: https://github.com/vuejs/vitepress/blob/main/src/node/markdown/plugins/link.ts
There was a problem hiding this comment.
I'm not sure if this is a common feature. Both vuepress and vitepress have lots of different customizations in their links plugin.
If it could be extract to a more customizable markdown-it plugin, maybe we can add it to https://github.com/mdit-vue/mdit-vue
There was a problem hiding this comment.
Oh I see! I misunderstood what antfu meant by we could do it in a plugin. This makes sense and thanks for the references! I'll look into developing this into a markdown-it plugin instead. Thanks so much for both of your time.
| Closing this PR and will look into making this into Markdown-it plugin instead. Thanks @antfu and @meteorlxy for the advice and your time! |
3 participants
Description
Adds an option to convert internal links to
RouterLinks. Supports custom router link components. I've also added a new test suite calledrouterLink.test.ts. It contains a total of 4 tests.Linked Issues
fix #37
Additional context