feat!: Making AccessToken Identity required #875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| throw new Error("secret is required"); | ||
| } | ||
| options = options || {}; | ||
| if (!options || !options.identity) { |
There was a problem hiding this comment.
Is this first !-check needed?
There was a problem hiding this comment.
Good catch, removed.
There was a problem hiding this comment.
Actually this breaks if options is undefined. https://github.com/twilio/twilio-node/actions/runs/3857410255/jobs/6574774047
There was a problem hiding this comment.
Ah, I see. Or simply !options?.identity
rakatyal force-pushed the accesstoken_identity branch from c5960c6 to fc82d45 Compare 
childish-sambino approved these changes Jan 6, 2023
| SonarCloud Quality Gate failed. |
| Fixes #595 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
JIRA: DI-2445
Making Identity required in the AccessToken constructor.