feat: blocking parameter on lock constructor with tests and docs #325
+127 −14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
gaborbernat approved these changes Apr 27, 2024
| Hey @gaborbernat, thanks for the swift approval! I don't have rights to squash and merge this PR. Feel free to do so whenever it fits. |
Merged
Merged
Closed
1 task
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Hey all, I'm Amon and this is my first PR here. Let me know if something's missing or not up to standards :)
PR Summary
blockingparameter on lock constructor. Similar in effect toblockingonBaseFileLock.acquiretimeout=0which was the previous way to have a non-blocking lock when using context manager syntax.I added some docs so this should close #64.