Upgrade lightningcss to 1.30.0 #17979
Conversation
philipp-spiess force-pushed the chore/lightningcss branch from a40dfd5 to 779f2fb Compare philipp-spiess force-pushed the chore/lightningcss branch from 779f2fb to 3c0d44c Compare 
RobinMalfait changed the title 1.20.01.30.0 
RobinMalfait left a comment
RobinMalfait left a comment There was a problem hiding this comment.
Just a small question, I wonder why some of the rules are split right now.
Can you also add a changelog entry?
| .shadow-xl { | ||
| box-shadow: var(--tw-inset-shadow), var(--tw-inset-ring-shadow), var(--tw-ring-offset-shadow), var(--tw-ring-shadow), var(--tw-shadow); | ||
| } |
There was a problem hiding this comment.
Interesting, what happened here 🤔
There was a problem hiding this comment.
I think this is fixing an issue in ordering where previously the --tw-shadow could sometimes appear after the box-shadow assignment because of how @supports was resolved. This generates more code now but it's corrent in a sense that even if the supports query works, the assignment is in the right order still.
There was a problem hiding this comment.
Yeah that's fair, just an interesting change. I would be smaller again if we didn't have the @supports but this is fine (and correct) so let's merge it!
2 participants
Uh oh!
There was an error while loading. Please reload this page.