Make polyfill work when the theme variable resolves to another var #17562
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Discovered while triaging #17556
This PR improves the
color-mix(...)polyfill to ensure it works when a theme key links to another theme key via avar(...)call.Imagine this setup:
Since
--color-redwill link to--color-red-500which is also a known theme variable, we can inline the value of--color-red-500into the fallback now:This will allow for slightly less confusing behavior.
The code added also handles recursive definitions where a color is linking to another color that is again linking to the first one (by adding a
Setto keep track of already seen variable names).Test plan