Skip to content

Extract keyframe name when followed by comma #17352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
philipp-spiess merged 2 commits into from
Mar 24, 2025
Merged

Extract keyframe name when followed by comma #17352

philipp-spiess merged 2 commits into from
Mar 24, 2025

Conversation

@philipp-spiess
Copy link
Member

@philipp-spiess philipp-spiess commented Mar 24, 2025 •
edited
Loading

Fixes #17332

This PR ensures that keyframes are emitted even when they are referenced following a comma, e.g.:

@theme { --animate-test: 500ms both fade-in, 1000ms linear 500ms spin infinite; /* ^ */ @keyframes fade-in { from { opacity: 0%; } to { opacity: 100%; } } }

Test plan

Added a unit test to capture the issue from #17332
@philipp-spiess philipp-spiess requested a review from a team as a code owner March 24, 2025 11:06
@philipp-spiess philipp-spiess merged commit e8715d0 into main Mar 24, 2025
6 checks passed
@philipp-spiess philipp-spiess deleted the fix/keyframe-emit branch March 24, 2025 11:25
@fossabot fossabot bot mentioned this pull request Oct 25, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@philipp-spiess @RobinMalfait