This repository was archived by the owner on Nov 23, 2021. It is now read-only.
Fix "WithoutKeepAlive" test to run and pass on Linux, plus provide more accurate name #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Also, Rename test to provide more accurate description
seabaylea reviewed Oct 16, 2017
| ("testSimpleHelloEndToEnd", testSimpleHelloEndToEnd), | ||
| ("testRequestEchoEndToEnd", testRequestEchoEndToEnd), | ||
| ("testRequestKeepAliveEchoEndToEnd", testRequestKeepAliveEchoEndToEnd), | ||
| ("testMultipleSimultaneousRequestsEchoEndToEnd",testMultipleSimultaneousRequestsEchoEndToEnd), |
Member
There was a problem hiding this comment.
Minor nit - should have a space.
Member
There was a problem hiding this comment.
There's also whitespace issues on lines 285->287 which could be fixed up at the same time.
Member
| @carlbrown could you make the minor changes above? Then we can get this in. |
Contributor Author
| This test no longer exists where it was when this PR was opened. Can't merge. |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.