Skip to content
This repository was archived by the owner on Nov 23, 2021. It is now read-only.

Conversation

@gtaban
Copy link
Collaborator

@gtaban gtaban commented Jan 10, 2018

No description provided.

@gtaban gtaban requested a review from carlbrown January 10, 2018 20:17
Copy link
Contributor

@carlbrown carlbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A couple of minor things


/// Stop the server
func stop()

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need this anymore.

#endif
}

//print("listeningPort is \(listeningPort)")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this.

Copy link
Contributor

@carlbrown carlbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbrown carlbrown merged commit 8a5668c into swift-server:develop Jan 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants