Skip to content
This repository was archived by the owner on Nov 23, 2021. It is now read-only.

Conversation

@GeorgeLyon
Copy link

…to actual response headers.

Previously, this honor was only bestowed upon status 100 "Continue".

…to actual response headers. Previously, this honor was only bestowed upon status 100 "Continue".
@helje5
Copy link
Contributor

helje5 commented Nov 12, 2017

Sounds good, do you want to do 101 or something else?

@GeorgeLyon
Copy link
Author

101 is special (and would probably need to be handled separately).
I'm actually hoping to use this to avoid using 101 (to upgrade to websockets) and instead use 102 or an application-specific code to enable long-polling.
There is also 103 (currently in draft) which allows you to specify the "Link" header any number of times before the full response is provided.

@helje5
Copy link
Contributor

helje5 commented Nov 12, 2017

Yes, upgrade has special support in the parser too. Needs to be implemented, right now we don't even have API for that. (in a way we really need a stream abstraction to make this work)

Copy link
Contributor

@carlbrown carlbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me.

@carlbrown carlbrown merged commit 4eab465 into swift-server:develop Nov 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants