Skip to content

pref(es/common): use next rather than nth #10403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 23, 2025
Merged

pref(es/common): use next rather than nth #10403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f95f310
pref(es/common): use next rather than nth
bvanjoi Apr 23, 2025
1ab753e
Create flat-humans-sneeze.md
kdy1 Apr 23, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/flat-humans-sneeze.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
swc_core: patch
swc_common: patch
---

pref(es/common): use next rather than nth
11 changes: 9 additions & 2 deletions crates/swc_common/src/input.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,12 +80,19 @@ impl Input for StringInput<'_> {

#[inline]
fn peek(&mut self) -> Option<char> {
self.iter.clone().nth(1)
let mut iter = self.iter.clone();
// https://github.com/rust-lang/rust/blob/1.86.0/compiler/rustc_lexer/src/cursor.rs#L56 say `next` is faster.
iter.next();
iter.next()
}

#[inline]
fn peek_ahead(&mut self) -> Option<char> {
self.iter.clone().nth(2)
let mut iter = self.iter.clone();
// https://github.com/rust-lang/rust/blob/1.86.0/compiler/rustc_lexer/src/cursor.rs#L56 say `next` is faster
iter.next();
iter.next();
iter.next()
}

#[inline]
Expand Down
Loading