Skip to content

Conversation

@bvanjoi
Copy link
Contributor

@bvanjoi bvanjoi commented Apr 23, 2025

https://github.com/rust-lang/rust/blob/1.86.0/compiler/rustc_lexer/src/cursor.rs#L56 mentions that using next is more optimized than nth, let's give this optimization a try.

@bvanjoi bvanjoi requested a review from a team as a code owner April 23, 2025 04:23
@changeset-bot
Copy link

changeset-bot bot commented Apr 23, 2025

🦋 Changeset detected

Latest commit: 1ab753e

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

CPunisher
CPunisher previously approved these changes Apr 23, 2025
kdy1
kdy1 previously approved these changes Apr 23, 2025
@kdy1 kdy1 added this to the Planned milestone Apr 23, 2025
@kdy1 kdy1 dismissed stale reviews from CPunisher and themself via 1ab753e April 23, 2025 14:21
@kdy1 kdy1 merged commit 12c2807 into swc-project:main Apr 23, 2025
17 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.11.22 Apr 23, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 23, 2025

CodSpeed Performance Report

Merging #10403 will degrade performances by 2.08%

Comparing bvanjoi:pref-3 (1ab753e) with main (a0e89f0)

Summary

❌ 1 regressions
✅ 145 untouched benchmarks
🆕 6 new benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
serialization of serde 2.8 µs 2.8 µs -2.08%
🆕 es/fixer/typescript N/A 205.5 ms N/A
🆕 es/hygiene/typescript N/A 533.6 ms N/A
🆕 es/resolver/typescript N/A 251.5 ms N/A
🆕 es/resolver_with_hygiene/typescript N/A 917.2 ms N/A
🆕 hygiene/typescript N/A 26.3 s N/A
🆕 resolver/typescript N/A 12.7 s N/A
@swc-project swc-project locked as resolved and limited conversation to collaborators May 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants