feat: add GamepadEventHandler type #9864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Add GamepadEventHandler type for window.addEventListener `gamepadconnected` and `gamepaddisconnected`
🦋 Changeset detectedLatest commit: d032ff4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ntsd commented Dec 8, 2023
| z?: number | string | undefined | null; | ||
| zoomAndPan?: string | undefined | null; | ||
| | ||
| // allow any data- attribute |
Contributor Author
There was a problem hiding this comment.
this one found after just auto format
5 tasks
Contributor
| Need to fix lint issues :) |
Contributor Author
Line success on my local. Seem like the Acron version update in this PR #9746 breaks the import Line 52 in 2f71c16 $ pnpm run lint > svelte-monorepo@0.0.1 lint /home/ntsd/git/ntsd/svelte > cd packages/svelte && pnpm build && cd ../../ && pnpm -r lint > svelte@4.2.8 build /home/ntsd/git/ntsd/svelte/packages/svelte > rollup -c && pnpm types src/compiler/index.js → compiler.cjs... (!) Circular dependencies src/compiler/compile/render_dom/wrappers/Fragment.js -> src/compiler/compile/render_dom/wrappers/AwaitBlock.js -> src/compiler/compile/render_dom/wrappers/Fragment.js src/compiler/compile/nodes/shared/map_children.js -> src/compiler/compile/nodes/AwaitBlock.js -> src/compiler/compile/nodes/PendingBlock.js -> src/compiler/compile/nodes/shared/map_children.js src/compiler/compile/nodes/ThenBlock.js -> src/compiler/compile/nodes/shared/get_const_tags.js -> src/compiler/compile/nodes/shared/map_children.js -> src/compiler/compile/nodes/AwaitBlock.js -> src/compiler/compile/nodes/ThenBlock.js ...and 18 more created compiler.cjs in 1.8s > svelte@4.2.8 types /home/ntsd/git/ntsd/svelte/packages/svelte > node ./scripts/generate-dts.js Scope: 3 of 4 workspace projects packages/svelte lint$ prettier . --cache --plugin-search-dir=. --check && eslint "{scripts,src,test}/**/*.js" --cache │ Checking formatting... │ All matched files use Prettier code style! └─ Done in 5.1s |
dummdidumm approved these changes Dec 11, 2023
Member
| The Acorn thing is unrelated and happening for a while now. I'll look into this the coming days |
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Add GamepadEventHandler type for window.addEventListener
gamepadconnectedandgamepaddisconnectedRef: https://developer.mozilla.org/en-US/docs/Web/API/GamepadEvent
Same with #9861 but merge to Svelte 4
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.Tests and linting
pnpm testand lint the project withpnpm lint