Skip to content

fix: preprocessor regex #9486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Rich-Harris merged 1 commit into from
Nov 16, 2023
Merged

fix: preprocessor regex #9486

Rich-Harris merged 1 commit into from
Nov 16, 2023

Conversation

@dummdidumm
Copy link
Member

@dummdidumm dummdidumm commented Nov 16, 2023

Related to sveltejs/language-tools#2204

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint
@changeset-bot
Copy link

changeset-bot bot commented Nov 16, 2023

🦋 Changeset detected

Latest commit: 986fc32

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
Copy link

vercel bot commented Nov 16, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-5-preview ❌ Failed (Inspect) Nov 16, 2023 2:24pm
@Rich-Harris Rich-Harris merged commit b2e1f1c into svelte-4 Nov 16, 2023
@Rich-Harris Rich-Harris deleted the preprocessor-regex branch November 16, 2023 14:33
@github-actions github-actions bot mentioned this pull request Nov 16, 2023
Merged
dummdidumm added a commit that referenced this pull request Nov 16, 2023
@dummdidumm
fix: tweak script/style tag parsing/preprocessing logic
1807e88 
Related to sveltejs/language-tools#2204 / sveltejs/language-tools#2039 The Svelte 5 version of #9486 and #9498
@dummdidumm dummdidumm mentioned this pull request Nov 16, 2023
Merged
5 tasks
dummdidumm added a commit that referenced this pull request Nov 17, 2023
@dummdidumm @Rich-Harris
fix: tweak script/style tag parsing/preprocessing logic (#9502)
1beb5e8 
Related to sveltejs/language-tools#2204 / sveltejs/language-tools#2039 The Svelte 5 version of #9486 and #9498 --------- Co-authored-by: Rich Harris <richard.a.harris@gmail.com> Co-authored-by: Rich Harris <rich.harris@vercel.com>
@mustafa0x mustafa0x mentioned this pull request Nov 19, 2023
Merged
5 tasks
@ovx ovx mentioned this pull request Oct 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@dummdidumm @Rich-Harris