fix: improve a11y-click-events-have-key-events message #9358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 097255c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
brunnerh reviewed Oct 27, 2023
There was a problem hiding this comment.
Thank you, for taking the initiative in trying to tackle this.
While this is better, it unfortunately still has issues:
- The keyboard events will do nothing unless the element or one of the descendants is focused (by default, non-interactive elements will not be focusable)
- The message does not explain that the keyboard handlers should enable the user to perform equivalent actions via the keyboard.
Because this is a lot, I was wondering whether delegating to the documentation for further explanation might be an option.
Speaking of which, the documentation at /docs/05-misc/02-accessibility-warnings.md should also be updated accordingly.
| Thanks for the review! Updated as suggested! |
brunnerh reviewed Oct 28, 2023
benmccann commented Oct 28, 2023
benmccann commented Oct 29, 2023
brunnerh approved these changes Oct 29, 2023
geoffrich approved these changes Oct 30, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
fixes #8001
closes #8273
it's longer message, but at least it's useful now