Skip to content

fix: Add missing plaintext-only value to contenteditable type #9242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dummdidumm merged 1 commit into from
Oct 19, 2023
Merged

fix: Add missing plaintext-only value to contenteditable type #9242

dummdidumm merged 1 commit into from
Oct 19, 2023

Conversation

@vhladko
Copy link
Contributor

@vhladko vhladko commented Sep 21, 2023 •
edited
Loading

Svelte compiler rewrite

As it was mentioned in #9181 contenteditable property was incomplete and missing 'plaintext-only'. This PR actually add this value to type.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint
@changeset-bot
Copy link

changeset-bot bot commented Sep 21, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: e479d04

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR
@vhladko vhladko force-pushed the fix-9181-correct-contenteditable-type branch from 27568cc to 0697051 Compare September 21, 2023 17:33
@jasonlyu123
Copy link
Member

jasonlyu123 commented Sep 22, 2023

As the bot mentioned, This needs a changeset.
@vhladko vhladko force-pushed the fix-9181-correct-contenteditable-type branch from 0697051 to e479d04 Compare September 22, 2023 08:01
@vhladko
Copy link
Contributor Author

vhladko commented Sep 22, 2023

As the bot mentioned, This needs a changeset.

my bad, just added :)
@vhladko
Copy link
Contributor Author

vhladko commented Sep 29, 2023

@jasonlyu123 can it be merged ?
dummdidumm
dummdidumm approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
@dummdidumm dummdidumm merged commit ab80d9d into sveltejs:master Oct 19, 2023
@github-actions github-actions bot mentioned this pull request Oct 19, 2023
Merged
kelvinsjk pushed a commit to kelvinsjk/svelte that referenced this pull request Oct 19, 2023
@vhladko @kelvinsjk
fix: add missing plaintext-only value to contenteditable type (svelte…
1b7c387 
…js#9242) fixes sveltejs#9181
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@vhladko @jasonlyu123 @dummdidumm