fix: This makes the indeterminate HTML attribute available for use. Fixes #9176. #9180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3c08ec4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jasonlyu123 reviewed Sep 6, 2023
packages/svelte/test/validator/samples/indeterminate-attribute/errors.json Outdated Show resolved Hide resolved
paulreece force-pushed the indeterminate_addition branch 3 times, most recently from f40f1c0 to 3e2f888 Compare 
Contributor Author
| @jasonlyu123 Please let me know if I can do anything else in regards to this pull request. |
Member
| Oh I forgot about it. As the bot commented, this needs a changeset. |
paulreece force-pushed the indeterminate_addition branch from 3e2f888 to e181dd6 Compare Contributor Author
| Just added one, thank you! |
jasonlyu123 approved these changes Sep 13, 2023
dummdidumm approved these changes Sep 20, 2023
Merged
kelvinsjk pushed a commit to kelvinsjk/svelte that referenced this pull request Oct 19, 2023
…ixes sveltejs#9176. (sveltejs#9180) Fixes sveltejs#9176. This adds indeterminate to the list of HTMLAttributes so that one can use it without receiving an error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.Tests and linting
pnpm testand lint the project withpnpm lintFixes #9176. This adds
indeterminateto the list ofHTMLAttributesso that one can use it without receiving an error.