Skip to content

Conversation

@gtm-nayan
Copy link
Contributor

@gtm-nayan gtm-nayan commented Aug 20, 2023

closes #5943

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint
@changeset-bot
Copy link

changeset-bot bot commented Aug 20, 2023

🦋 Changeset detected

Latest commit: add87ae

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dummdidumm
Copy link
Member

I vaguely remember that @tanhauhau did something similar a year or more ago but that introduced a bug. Anyone has any ideas what that was, or am I misremembering? cc @Conduitry

@Conduitry
Copy link
Member

What immediately springs to mind is #7942 (which we had to revert), but that was less than a year ago. Although it was based on #4066 which was a few years older.

@dummdidumm
Copy link
Member

dummdidumm commented Aug 20, 2023

Ah yeah I meant the first one you mentioned ,thanks for digging it up

@gtm-nayan
Copy link
Contributor Author

gtm-nayan commented Aug 20, 2023

Is there a test case to prevent the regression from #7942, going by the tests at least this shouldn't break anything because the dirty & 0 that's removed now would've never been true anyway.

@Conduitry
Copy link
Member

Yeah it looks like #8382 (which reverted #7942) included a new test.

@dummdidumm dummdidumm merged commit 115ea1f into master Sep 20, 2023
@dummdidumm dummdidumm deleted the module-variable-dirty-check branch September 20, 2023 07:48
@github-actions github-actions bot mentioned this pull request Sep 20, 2023
kelvinsjk pushed a commit to kelvinsjk/svelte that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants