fix: handle patterns in destructured literals #8871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
benmccann reviewed Jul 8, 2023
Member
| Hmm. I have no idea why lint is failing due to some site error since merging in the latest changes from |
Collaborator
| That is happening because the get_contributors.js script, when trying to fetch from github, is getting an error response, which is failing in the Array.isArray check. Im sure its no problem, retriggering lint should make it go away |
Contributor Author
| Yeah, reran it a few minutes ago and the error went away. |
benmccann reviewed Jul 8, 2023
benmccann reviewed Jul 8, 2023
benmccann approved these changes Jul 9, 2023
Member
benmccann left a comment
benmccann left a comment There was a problem hiding this comment.
lgtm though it should probably get a final approval from someone with more svelte core experience
benmccann reviewed Jul 10, 2023
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
benmccann force-pushed the hoistability-destruct-literal branch from f72d5ac to bd65818 Compare benmccann reviewed Jul 10, 2023
benmccann reviewed Jul 11, 2023
dummdidumm approved these changes Jul 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
fixes #8863
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.Tests and linting
pnpm testand lint the project withpnpm lint