Skip to content

fix: Make sure 'func' doesn't clash with destructured contexts #8840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dummdidumm merged 3 commits into from
Jun 27, 2023
Merged

fix: Make sure 'func' doesn't clash with destructured contexts #8840

dummdidumm merged 3 commits into from
Jun 27, 2023

Conversation

@ngtr6788
Copy link
Contributor

@ngtr6788 ngtr6788 commented Jun 25, 2023

Fixes: #8753

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint
@dummdidumm
Copy link
Member

dummdidumm commented Jun 26, 2023

Thank you! Could you add a changeset (you can run npx changeset at the root of the monorepo and follow the prompt)? Then we're good to go 👍
@ngtr6788
Copy link
Contributor Author

ngtr6788 commented Jun 27, 2023

Thank you! Could you add a changeset (you can run npx changeset at the root of the monorepo and follow the prompt)? Then we're good to go 👍

Done!
dummdidumm
dummdidumm approved these changes Jun 27, 2023
View reviewed changes
@dummdidumm dummdidumm merged commit 3576c74 into sveltejs:master Jun 27, 2023
@github-actions github-actions bot mentioned this pull request Jun 27, 2023
Merged
@ngtr6788 ngtr6788 deleted the func-destructure-clash branch July 6, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@ngtr6788 @dummdidumm