Skip to content

chore: deindent cjs output for compiler #8785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dummdidumm merged 3 commits into from
Jun 22, 2023
Merged

chore: deindent cjs output for compiler #8785

dummdidumm merged 3 commits into from
Jun 22, 2023

Conversation

@gtm-nayan
Copy link
Contributor

@gtm-nayan gtm-nayan commented Jun 22, 2023 •
edited
Loading

Removes a level of indentation inside the UMD wrapper. It's not much but -40KiB unpacked and about -6KiB gzipped (lol)

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint
gtm-nayan
gtm-nayan commented Jun 22, 2023
View reviewed changes
dummdidumm
dummdidumm approved these changes Jun 22, 2023
View reviewed changes
Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every bit counts! 😄
@dummdidumm dummdidumm merged commit 0394216 into master Jun 22, 2023
@dummdidumm dummdidumm deleted the deindent branch June 22, 2023 08:41
This was referenced Jun 22, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@gtm-nayan @dummdidumm