fix: backwards compatibility for types #8721

gtm-nayan · 2023-06-11T15:57:38Z

HEADS UP: BIG RESTRUCTURING UNDERWAY

The Svelte repo is currently in the process of heavy restructuring for Svelte 4. After that, work on Svelte 5 will likely change a lot on the compiler aswell. For that reason, please don't open PRs that are large in scope, touch more than a couple of files etc. In other words, bug fixes are fine, but feature PRs will likely not be merged.

Before submitting the PR, please make sure you do the following

It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
Prefix your PR title with feat:, fix:, chore:, or docs:.
This message body should clearly illustrate what problems it solves.
Ideally, include a test that fails without this PR but passes with it.

Tests

Run the tests with npm test and lint the project with npm run lint

vercel · 2023-06-11T15:57:42Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
svelte-dev-2	❌ Failed (Inspect)			Jun 15, 2023 6:52pm

gtm-nayan · 2023-06-11T16:01:33Z

/ecosystem-ci run

svelte-ecoystem-ci · 2023-06-11T16:01:53Z

📝 Ran ecosystem CI: Open

suite	result
eslint-plugin-svelte	❌ failure
language-tools	❌ failure
mdsvex	❌ failure
prettier-plugin-svelte	❌ failure
rollup-plugin-svelte	❌ failure
skeleton	❌ failure
svelte-eslint-parser	❌ failure
svelte-loader	❌ failure
svelte-preprocess	❌ failure
sveltekit	❌ failure
vite-plugin-svelte	❌ failure

gtm-nayan · 2023-06-11T16:07:20Z

/ecosystem-ci run

svelte-ecoystem-ci · 2023-06-11T16:07:42Z

📝 Ran ecosystem CI: Open

suite	result
eslint-plugin-svelte	✅ success
language-tools	❌ failure
mdsvex	❌ failure
prettier-plugin-svelte	✅ success
rollup-plugin-svelte	✅ success
skeleton	✅ success
svelte-eslint-parser	✅ success
svelte-loader	✅ success
svelte-preprocess	✅ success
sveltekit	❌ failure
vite-plugin-svelte	❌ failure

gtm-nayan · 2023-06-11T16:17:11Z

/ecosystem-ci run

svelte-ecoystem-ci · 2023-06-11T16:17:37Z

📝 Ran ecosystem CI: Open

suite	result
eslint-plugin-svelte	✅ success
language-tools	❌ failure
mdsvex	❌ failure
prettier-plugin-svelte	✅ success
rollup-plugin-svelte	✅ success
skeleton	✅ success
svelte-eslint-parser	✅ success
svelte-loader	✅ success
svelte-preprocess	✅ success
sveltekit	❌ failure
vite-plugin-svelte	❌ failure

gtm-nayan · 2023-06-11T16:21:54Z

gtm-nayan · 2023-06-11T16:28:53Z

/ecosystem-ci run

svelte-ecoystem-ci · 2023-06-11T16:29:14Z

📝 Ran ecosystem CI: Open

suite	result
eslint-plugin-svelte	✅ success
language-tools	⏹️ cancelled
mdsvex	⏹️ cancelled
prettier-plugin-svelte	✅ success
rollup-plugin-svelte	✅ success
skeleton	✅ success
svelte-eslint-parser	✅ success
svelte-loader	✅ success
svelte-preprocess	✅ success
sveltekit	⏹️ cancelled
vite-plugin-svelte	✅ success

svelte-ecoystem-ci · 2023-06-11T16:41:30Z

📝 Ran ecosystem CI: Open

suite	result
eslint-plugin-svelte	✅ success
language-tools	❌ failure
mdsvex	❌ failure
prettier-plugin-svelte	✅ success
rollup-plugin-svelte	✅ success
skeleton	✅ success
svelte-eslint-parser	✅ success
svelte-loader	✅ success
svelte-preprocess	✅ success
sveltekit	❌ failure
vite-plugin-svelte	✅ success

dummdidumm · 2023-06-11T17:15:53Z

packages/svelte/scripts/generate-dts.js

+fs.mkdirSync('types/faux', { recursive: true });
+fs.readdirSync('src/runtime', { withFileTypes: true })
+.filter((dirent) => dirent.isDirectory())
+.forEach((dirent) =>


Does this include internal? Should be filtered out probably

gtm-nayan · 2023-06-12T02:51:29Z

/ecosystem-ci run

svelte-ecoystem-ci · 2023-06-12T02:51:51Z

📝 Ran ecosystem CI: Open

suite	result
eslint-plugin-svelte	✅ success
language-tools	❌ failure
mdsvex	❌ failure
prettier-plugin-svelte	✅ success
rollup-plugin-svelte	✅ success
skeleton	✅ success
svelte-eslint-parser	✅ success
svelte-loader	✅ success
svelte-preprocess	✅ success
sveltekit	❌ failure
vite-plugin-svelte	✅ success

gtm-nayan · 2023-06-12T04:12:13Z

/ecosystem-ci run

svelte-ecoystem-ci · 2023-06-12T04:12:35Z

📝 Ran ecosystem CI: Open

suite	result
eslint-plugin-svelte	✅ success
language-tools	❌ failure
mdsvex	❌ failure
prettier-plugin-svelte	✅ success
rollup-plugin-svelte	✅ success
skeleton	✅ success
svelte-eslint-parser	✅ success
svelte-loader	✅ success
svelte-preprocess	✅ success
sveltekit	❌ failure
vite-plugin-svelte	✅ success

svelte-ecoystem-ci · 2023-06-16T20:16:58Z

📝 Ran ecosystem CI: Open

suite	result
eslint-plugin-svelte	❌ failure
language-tools	❌ failure
mdsvex	❌ failure
prettier-plugin-svelte	❌ failure
rollup-plugin-svelte	❌ failure
skeleton	❌ failure
svelte-eslint-parser	❌ failure
svelte-loader	❌ failure
svelte-preprocess	❌ failure
sveltekit	❌ failure
vite-plugin-svelte	❌ failure

dummdidumm · 2023-06-16T20:29:16Z

/ecosystem-ci run

svelte-ecoystem-ci · 2023-06-16T20:29:42Z

📝 Ran ecosystem CI: Open

suite	result
eslint-plugin-svelte	✅ success
language-tools	❌ failure
mdsvex	❌ failure
prettier-plugin-svelte	✅ success
rollup-plugin-svelte	✅ success
skeleton	✅ success
svelte-eslint-parser	✅ success
svelte-loader	✅ success
svelte-preprocess	✅ success
sveltekit	❌ failure
vite-plugin-svelte	✅ success

dummdidumm · 2023-06-16T21:04:48Z

/ecosystem-ci run

svelte-ecoystem-ci · 2023-06-16T21:05:14Z

📝 Ran ecosystem CI: Open

suite	result
eslint-plugin-svelte	✅ success
language-tools	❌ failure
mdsvex	✅ success
prettier-plugin-svelte	✅ success
rollup-plugin-svelte	✅ success
skeleton	✅ success
svelte-eslint-parser	✅ success
svelte-loader	✅ success
svelte-preprocess	✅ success
sveltekit	❌ failure
vite-plugin-svelte	✅ success

dummdidumm · 2023-06-16T21:09:17Z

I think most things are fixed, one is missing: SvelteComponent is exported publicly, not SvelteComponentDev. dts-buddy does not seem to handle the export { Sth as SthElse } from '..' case, it just ignores the aliasing. I looked into what it means just exposing SvelteComponent but that would mean changes to the runtime code which are invalid strictly speaking and which increases the bundle size by a tiny amount for no good reason. That's because we need to type a constructor and type some instance fields, both are not actually needed by the Svelte runtime. @Rich-Harris / @gtm-nayan if one of you could look into dts-buddy that would be great, else I'll try to tackle this on monday.

dummdidumm · 2023-06-16T21:21:49Z

/ecosystem-ci run

svelte-ecoystem-ci · 2023-06-16T21:22:14Z

📝 Ran ecosystem CI: Open

suite	result
eslint-plugin-svelte	✅ success
language-tools	❌ failure
mdsvex	✅ success
prettier-plugin-svelte	✅ success
rollup-plugin-svelte	✅ success
skeleton	✅ success
svelte-eslint-parser	✅ success
svelte-loader	✅ success
svelte-preprocess	✅ success
sveltekit	❌ failure
vite-plugin-svelte	✅ success

dummdidumm · 2023-06-17T20:28:24Z

/ecosystem-ci run

svelte-ecoystem-ci · 2023-06-17T20:28:50Z

📝 Ran ecosystem CI: Open

suite	result
eslint-plugin-svelte	✅ success
language-tools	❌ failure
mdsvex	✅ success
prettier-plugin-svelte	✅ success
rollup-plugin-svelte	✅ success
skeleton	✅ success
svelte-eslint-parser	✅ success
svelte-loader	✅ success
svelte-preprocess	✅ success
sveltekit	❌ failure
vite-plugin-svelte	✅ success

dummdidumm · 2023-06-17T20:46:13Z

Ok I found a workaround for the dts-buddy bug. Ecosystem CI run looks mostly good now. SvelteKit tests - no idea why they failed, maybe unrelated. language-tools: one needs a change in language-tools due to where the declare module '*.svelte' declaration lives now, the other failure needs investigation.

dummdidumm · 2023-06-18T18:40:12Z

/ecosystem-ci run

svelte-ecoystem-ci · 2023-06-18T18:40:38Z

📝 Ran ecosystem CI: Open

suite	result
eslint-plugin-svelte	✅ success
language-tools	❌ failure
mdsvex	✅ success
prettier-plugin-svelte	✅ success
rollup-plugin-svelte	✅ success
skeleton	✅ success
svelte-eslint-parser	✅ success
svelte-loader	✅ success
svelte-preprocess	✅ success
sveltekit	✅ success
vite-plugin-svelte	✅ success

dummdidumm · 2023-06-18T19:10:28Z

Nice, ecosystem-ci is green again (that red cross from language tools is a timeout, that happens from time to time)

fix:backwards compatibility for types

64e7987

update package json

94522ee

vercel bot had a problem deploying to Preview June 11, 2023 15:58 Failure

what an idiot

26c5568

vercel bot had a problem deploying to Preview June 11, 2023 16:06 Failure

replace SvelteComponentDev

c3730b8

vercel bot had a problem deploying to Preview June 11, 2023 16:16 Failure

work already

d6b7b24

vercel bot had a problem deploying to Preview June 11, 2023 16:27 Failure

dummdidumm reviewed Jun 11, 2023

View reviewed changes

remove indirection

ba3140d

vercel bot had a problem deploying to Preview June 12, 2023 02:51 Failure

this maybe?

e9d9dec

vercel bot had a problem deploying to Preview June 12, 2023 04:11 Failure

benmccann added this to the 4.x milestone Jun 12, 2023

vercel bot deployed to Preview June 16, 2023 20:18 View deployment

fix file endings

734bdd7

vercel bot deployed to Preview June 16, 2023 21:06 View deployment

generate index signature manually

0ad3db3

vercel bot deployed to Preview June 16, 2023 21:23 View deployment

work around dts-buddy bug

d067e2e

vercel bot deployed to Preview June 17, 2023 20:30 View deployment

dummdidumm added 2 commits June 18, 2023 20:38

simplify a bit

d8570c2

changeset

0195883

vercel bot deployed to Preview June 18, 2023 18:43 View deployment

dummdidumm marked this pull request as ready for review June 18, 2023 19:10

dummdidumm approved these changes Jun 18, 2023

View reviewed changes

dummdidumm merged commit cc82d5d into version-4 Jun 18, 2023

dummdidumm deleted the types-backcompat branch June 18, 2023 19:12

This was referenced Jun 18, 2023

Version Packages (next) #8733

Merged

Version Packages #8799

Merged

Uh oh!

fix: backwards compatibility for types #8721

fix: backwards compatibility for types #8721

Uh oh!

Conversation

gtm-nayan commented Jun 11, 2023

HEADS UP: BIG RESTRUCTURING UNDERWAY

Before submitting the PR, please make sure you do the following

Tests

vercel bot commented Jun 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

gtm-nayan commented Jun 11, 2023

svelte-ecoystem-ci bot commented Jun 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

gtm-nayan commented Jun 11, 2023

svelte-ecoystem-ci bot commented Jun 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

gtm-nayan commented Jun 11, 2023

svelte-ecoystem-ci bot commented Jun 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

gtm-nayan commented Jun 11, 2023

gtm-nayan commented Jun 11, 2023

svelte-ecoystem-ci bot commented Jun 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

svelte-ecoystem-ci bot commented Jun 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

dummdidumm Jun 11, 2023

Choose a reason for hiding this comment

gtm-nayan commented Jun 12, 2023

svelte-ecoystem-ci bot commented Jun 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

gtm-nayan commented Jun 12, 2023

svelte-ecoystem-ci bot commented Jun 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

svelte-ecoystem-ci bot commented Jun 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

dummdidumm commented Jun 16, 2023

svelte-ecoystem-ci bot commented Jun 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

dummdidumm commented Jun 16, 2023

svelte-ecoystem-ci bot commented Jun 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

dummdidumm commented Jun 16, 2023

dummdidumm commented Jun 16, 2023

svelte-ecoystem-ci bot commented Jun 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

dummdidumm commented Jun 17, 2023

svelte-ecoystem-ci bot commented Jun 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

dummdidumm commented Jun 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

dummdidumm commented Jun 18, 2023

svelte-ecoystem-ci bot commented Jun 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

dummdidumm commented Jun 18, 2023

Labels

5 participants

vercel bot commented Jun 11, 2023 •

edited

Loading

svelte-ecoystem-ci bot commented Jun 11, 2023 •

edited

Loading

svelte-ecoystem-ci bot commented Jun 11, 2023 •

edited

Loading

svelte-ecoystem-ci bot commented Jun 11, 2023 •

edited

Loading

svelte-ecoystem-ci bot commented Jun 11, 2023 •

edited

Loading

svelte-ecoystem-ci bot commented Jun 11, 2023 •

edited

Loading

svelte-ecoystem-ci bot commented Jun 12, 2023 •

edited

Loading

svelte-ecoystem-ci bot commented Jun 12, 2023 •

edited

Loading

svelte-ecoystem-ci bot commented Jun 16, 2023 •

edited

Loading

svelte-ecoystem-ci bot commented Jun 16, 2023 •

edited

Loading

svelte-ecoystem-ci bot commented Jun 16, 2023 •

edited

Loading

svelte-ecoystem-ci bot commented Jun 16, 2023 •

edited

Loading

svelte-ecoystem-ci bot commented Jun 17, 2023 •

edited

Loading

dummdidumm commented Jun 17, 2023 •

edited

Loading

svelte-ecoystem-ci bot commented Jun 18, 2023 •

edited

Loading