Skip to content

Conversation

@Rich-Harris
Copy link
Member

small tweak that fixes a gotcha I just encountered working with forks — if you call discard() on a fork that has already been committed (e.g. forks.forEach((f) => f.discard()), without removing the just-committed fork from forks) it will destroy any effects that are needed when the batch eventually resolves

no test because i am under a lot of time pressure 😬 but i consider a regression unlikely

also turned some lets and consts to vars, as is our wont. i also made double-commits no-ops, just like commit-discard.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint
@changeset-bot
Copy link

changeset-bot bot commented Oct 25, 2025

🦋 Changeset detected

Latest commit: 074aa3b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@17034 
@Rich-Harris Rich-Harris merged commit 657ec89 into main Oct 25, 2025
18 checks passed
@Rich-Harris Rich-Harris deleted the fork-discard-after-commit branch October 25, 2025 18:12
@github-actions github-actions bot mentioned this pull request Oct 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants