Skip to content

Conversation

@konstantinov90
Copy link

@konstantinov90 konstantinov90 commented Feb 22, 2024

fix 10602

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint
@changeset-bot
Copy link

changeset-bot bot commented Feb 22, 2024

🦋 Changeset detected

Latest commit: 47de201

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dummdidumm
Copy link
Member

Thank you, looks good! Could you add a changeset (using npx changeset at the root of the repo)? Then we're good to merge.

@konstantinov90
Copy link
Author

changeset done

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dummdidumm dummdidumm merged commit 055e7a8 into sveltejs:svelte-4 Feb 22, 2024
@github-actions github-actions bot mentioned this pull request Feb 22, 2024
@konstantinov90
Copy link
Author

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants