fix: false positives for regular components in valid-compile/custom_element_props_identifier (#1241) #1243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…lement_props_identifier (sveltejs#1241)
🦋 Changeset detectedLatest commit: cc28f3f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Try the Instant Preview in Online PlaygroundInstall the Instant Preview to Your LocalPublished Instant Preview Packages:
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #1241
My fix ensures we're only passing the
customElement: trueoption tocompile()when the code actually uses acustomElementoption (or the deprecatedtagoption).Test case
valid-compile/invalid/custom_element_props_identifier-errorstests thecustom_element_props_identifiererrorTest case
valid-compile/valid/valid-custom-element-with-props-identifiertests the resolution of thecustom_element_props_identifiererrorTest case
valid-compile/valid/no-false-custom_element_props_identifier-warning-without-custom-elementtests my fix for the false-positive of thecustom_element_props_identifieron a regular Svelte component (not a custom element)