- Notifications
You must be signed in to change notification settings - Fork 4k
Use key as main identity for st.checkbox & st.toggle #12372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ PR preview is ready!
|
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR modifies the identity computation for st.checkbox and st.toggle widgets to use the custom key parameter as the main identity when provided. This change allows dynamic parameter updates between reruns without widget recreation in the frontend, improving user experience by maintaining widget state when other properties change.
Key changes:
- Sets
key_as_main_identity=Truefor checkbox and toggle widgets when computing element IDs - Adds comprehensive unit tests to verify stable widget IDs with dynamic parameters
- Implements E2E tests demonstrating dynamic property updates while preserving widget state
Reviewed Changes
Copilot reviewed 6 out of 18 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
lib/streamlit/elements/widgets/checkbox.py | Changes identity computation to use key as main identity |
lib/tests/streamlit/elements/checkbox_test.py | Adds unit tests for stable ID behavior with key parameter |
e2e_playwright/st_checkbox.py | Adds dynamic checkbox test scenario with property updates |
e2e_playwright/st_checkbox_test.py | Implements E2E tests for dynamic checkbox behavior |
e2e_playwright/st_toggle.py | Adds dynamic toggle test scenario with property updates |
e2e_playwright/st_toggle_test.py | Implements E2E tests for dynamic toggle behavior |
key as main identity for checkbox & togglekey as main identity for st.checkbox & st.toggle Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
Describe your changes
If a custom
keyis passed to any of thest.checkbox/st.togglewidgets it will be used as the main identity. This allows for dynamically changing other parameters in between reruns without causing the widgets to be recreated in the frontend.GitHub Issue Link (if applicable)
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.