Detect C++ language from compiler arguments #175
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR improves C++ language detection by analyzing compiler arguments.
Before my PR, the language was detected by checking if "++" existed in the compiler name. This approach is incorrect in certain cases.
cppast/src/libclang/libclang_parser.cpp
Lines 232 to 234 in 5329e37
e.g my build utility xmake is only using
clang
notclang++
in thecompile_commands.json
and setting-std=c++20
.