Skip to content

Conversation

@dmjb
Copy link
Member

@dmjb dmjb commented Dec 3, 2025

Previously, we did not include the pinger for remote workloads. The assumption was that we may not be able to authenticate while pinging the remote, so we would not get the expected status. There were two issues which arose:

  • It turns out the pinger accepts any non 50x, so we do not need to worry about 401.
  • By excluding the pinger from the remote workload, we lack the ability to test basic connectivity to the remote workload. This has led to some reported issues where network connectivity is lost, and ToolHive is not aware that there is a problem.

This PR adds the pinger to the remote workload. In future, we may want to be more selective - for example, only allow 401s for remote workloads.

@github-actions github-actions bot added the size/XS Extra small PR: < 100 lines changed label Dec 3, 2025
JAORMX
JAORMX previously approved these changes Dec 3, 2025
Previously, we did not include the pinger for remote workloads. The assumption was that we may not be able to authenticate while pinging the remote, so we would not get the expected status. There were two issues which arose: - It turns out the pinger accepts any non 50x, so we do not need to worry about 401. - By excluding the pinger from the remote workload, we lack the ability to test basic connectivity to the remote workload. This has led to some reported issues where network connectivity is lost, and ToolHive is not aware that there is a problem. This PR adds the pinger to the remote workload. In future, we may want to be more selective - for example, only allow 401s for remote workloads.
@dmjb dmjb force-pushed the remote-workload-proxy-stuck branch from 8ddcd80 to 1258242 Compare December 3, 2025 15:12
@github-actions github-actions bot added size/XS Extra small PR: < 100 lines changed and removed size/XS Extra small PR: < 100 lines changed labels Dec 3, 2025
@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 56.65%. Comparing base (a5ff43f) to head (1258242).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pkg/transport/http.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@ ## main #2872 +/- ## ========================================== - Coverage 56.66% 56.65% -0.01%  ========================================== Files 322 322 Lines 31279 31279 ========================================== - Hits 17723 17721 -2  - Misses 12038 12040 +2  Partials 1518 1518 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@dmjb dmjb merged commit 66caa98 into main Dec 3, 2025
33 checks passed
@dmjb dmjb deleted the remote-workload-proxy-stuck branch December 3, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Extra small PR: < 100 lines changed

3 participants