Skip to content

Conversation

@amirejaz
Copy link
Contributor

@amirejaz amirejaz commented Dec 3, 2025

List workloads in group once at the start of ensureAllResources and pass the result to functions that need it, instead of listing at different times which could yield different results.

This ensures all functions use the same workload list snapshot, improving consistency and reducing API calls.

@github-actions github-actions bot added the size/S Small PR: 100-299 lines changed label Dec 3, 2025
@amirejaz amirejaz requested review from jhrozek and yrobla December 3, 2025 12:09
@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.68%. Comparing base (f57d84a) to head (cb6d3dc).
⚠️ Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...perator/controllers/virtualmcpserver_controller.go 58.33% 2 Missing and 3 partials ⚠️
...perator/controllers/virtualmcpserver_deployment.go 33.33% 4 Missing ⚠️
...perator/controllers/virtualmcpserver_vmcpconfig.go 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@ ## main #2867 +/- ## ========================================== + Coverage 56.59% 56.68% +0.08%  ========================================== Files 322 322 Lines 31247 31269 +22 ========================================== + Hits 17685 17725 +40  + Misses 12042 12028 -14  + Partials 1520 1516 -4 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@JAORMX JAORMX merged commit 15f0beb into main Dec 3, 2025
33 checks passed
@JAORMX JAORMX deleted the single-workload-list branch December 3, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Small PR: 100-299 lines changed

4 participants