Split out podTemplateBuilder to be reusable and cover with integration tests #2840
Conversation
… use it Extract shared PodTemplateSpec utilities to controllerutil Update MCPServer controller to use the shared PodTemplateSpecBuilder from controllerutil instead of the MCPServer-specific builder.
Add integration tests for MCPServer PodTemplateSpec functionality: - Resource limits (CPU/memory) applied to deployment containers - SecurityContext settings (runAsNonRoot, readOnlyRootFilesystem) - PodTemplateSpec updates trigger deployment reconciliation - Valid condition set to True for valid PodTemplateSpec JSON
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Large PR Detected
This PR exceeds 1000 lines of changes and requires justification before it can be reviewed.
How to unblock this PR:
Add a section to your PR description with the following format:
## Large PR Justification [Explain why this PR must be large, such as:] - Generated code that cannot be split - Large refactoring that must be atomic - Multiple related changes that would break if separated - Migration or data transformationAlternative:
Consider splitting this PR into smaller, focused changes (< 1000 lines each) for easier review and reduced risk.
See our Contributing Guidelines for more details.
This review will be automatically dismissed once you add the justification section.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@ ## main #2840 +/- ## ======================================= Coverage 56.61% 56.62% ======================================= Files 320 320 Lines 30932 30936 +4 ======================================= + Hits 17513 17517 +4 Misses 11914 11914 Partials 1505 1505 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jhrozek dismissed github-actions[bot]’s stale review I've provided the justification
We want to add a podTemplateSpec for vMCP, but in order to avoid code duplication, it would be nice to reuse as much as possible from MCPServer's podTemplateBuilder.
This PR makes the builder reusable and covers its usage with integration tests to make sure we don't regress.
Large PR Justification
Most of the size in the PR is adding integration tests. I /could/ add them separately but I don't see the point. Having them in the same PR ensures the PR doesn't introduce regressions.