Skip to content

Conversation

@jerm-dro
Copy link
Contributor

@jerm-dro jerm-dro commented Dec 2, 2025

Summary

Add debug logs that differentiate which type of MCP server we're attempting to run.

Fixes #2761

Implementation Details

The linked issue gestures towards an ideal solution where we have one log per type of MCP server. The existing code branches in quite a few places (e.g. there are two different paths for differentiating between remote and registry MCP servers). Instead of adding logging to these cases exhaustively, I opted to make an incremental improvement in the debug logs.

I'd prefer to consolidate the existing code into fewer branches before adding more logs, but if someone feels strongly LMK and I can accommodate.

Testing

I verified the new logs appear locally by running task build and then a series of bin/thv run --debug commands. Output pictured below:
Screenshot 2025-12-01 at 5 21 47 PM
Screenshot 2025-12-01 at 5 24 22 PM

@github-actions github-actions bot added the size/XS Extra small PR: < 100 lines changed label Dec 2, 2025
@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 56.61%. Comparing base (f0ce9c2) to head (5a9a1ce).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
pkg/runner/retriever/retriever.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@ ## main #2834 +/- ## ======================================= Coverage 56.61% 56.61% ======================================= Files 320 320 Lines 30932 30933 +1 ======================================= + Hits 17511 17513 +2  + Misses 11916 11915 -1  Partials 1505 1505 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Copy link
Member

@eleftherias eleftherias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @jerm-dro!
I added some comments about the nuances between registry servers, remote servers, and images.

@github-actions github-actions bot added size/XS Extra small PR: < 100 lines changed and removed size/XS Extra small PR: < 100 lines changed labels Dec 2, 2025
@jerm-dro jerm-dro requested a review from eleftherias December 2, 2025 16:45
@jerm-dro jerm-dro changed the title Add debug logs for thv run server location Add Debug Logs for thv run Server Location Dec 2, 2025
@jerm-dro jerm-dro merged commit df1b324 into main Dec 2, 2025
36 of 37 checks passed
@jerm-dro jerm-dro deleted the jerm/fix-2761 branch December 2, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Extra small PR: < 100 lines changed

4 participants