Make client_id optional in vMCP OIDC config #2822
Merged
+16 −4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
client_id is only required for specific flows like token introspection with client credentials. For standard JWT validation using JWKS, only issuer and audience are needed. This follows the same pattern as the previous change that made client_secret_env optional (d543c84).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@ ## main #2822 +/- ## ========================================== + Coverage 56.55% 56.56% +0.01% ========================================== Files 320 320 Lines 30874 30872 -2 ========================================== + Hits 17460 17462 +2 + Misses 11911 11908 -3 + Partials 1503 1502 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yrobla approved these changes Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
client_id is only required for specific flows like token introspection with client credentials. For standard JWT validation using JWKS, only issuer and audience are needed.
This follows the same pattern as the previous change that made client_secret_env optional (d543c84).