Extract MCP client setup to CreateInitializedMCPClient helper #2796
+72 −96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Add a new helper function that consolidates the common pattern of creating, starting, and initializing an MCP client. This reduces code duplication across test files and centralizes: - Client creation with NewStreamableHttpClient - Transport start - Initialize request with LATEST_PROTOCOL_VERSION - Proper resource cleanup The helper also properly handles cleanup on failure and includes explicit ClientCapabilities in the initialize request.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@ ## main #2796 +/- ## ======================================= Coverage 56.52% 56.52% ======================================= Files 319 319 Lines 30886 30886 ======================================= Hits 17458 17458 Misses 11924 11924 Partials 1504 1504 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JAORMX approved these changes Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Add a new helper function that consolidates the common pattern of creating, starting, and initializing an MCP client. This reduces code duplication across test files and centralizes:
The helper also properly handles cleanup on failure and includes explicit ClientCapabilities in the initialize request.