Add testing and code quality guidelines to CONTRIBUTING.md #2685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Add explicit requirements for testing (E2E and unit tests) and code quality expectations including PR size limits, code review responsibilities, and manual testing requirements. Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@ ## main #2685 +/- ## ======================================= Coverage 55.29% 55.30% ======================================= Files 315 315 Lines 30299 30299 ======================================= + Hits 16754 16756 +2 + Misses 12076 12074 -2 Partials 1469 1469 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ChrisJBurns reviewed Nov 21, 2025
ChrisJBurns approved these changes Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Add testing requirements section covering E2E and unit tests. Add code quality expectations section with clear PR size limits and responsibilities. Clarify that PRs over 1000 lines may be blocked and require justification.