Skip to content

Stop referring to Oracle STRUCT and ARRAY as they are deprecated #33248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Stop referring to Oracle STRUCT and ARRAY as they are deprecated #33248

wants to merge 4 commits into from

Conversation

@ngocnhan-tran1996
Copy link
Contributor

I see StructDescriptor and ArrayDescriptor have been deprecated.

Replace for StructDescriptor

Use factory method Connection.createStruct to create an instance of java.sql.Struct directly.

Replace for ArrayDescriptor

Use factory method OracleConnection.createOracleArray to create an instance of java.sql.Array directly.

StructDescriptor javadoc
ArrayDescriptor javadoc

That why I make this PR. Is it necessary to update document? If it is necessary, please update kotlin section.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jul 20, 2024
@snicoll snicoll self-assigned this Jul 21, 2024
@snicoll snicoll changed the title Update Complex Types for Stored Procedure Calls Document Section Stop referring to Oracle STRUCT and ARRAY as they are deprecated Jul 21, 2024
@snicoll snicoll added type: documentation A documentation task and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jul 21, 2024
@snicoll snicoll added this to the 6.1.12 milestone Jul 21, 2024
snicoll pushed a commit that referenced this pull request Jul 21, 2024
@ngocnhan-tran1996 @snicoll
Stop referring to STRUCT and ARRAY as they are deprecated
955602b 
See gh-33248
snicoll added a commit that referenced this pull request Jul 21, 2024
@snicoll
Polish "Stop referring to STRUCT and ARRAY as they are deprecated"
af8dc44 
See gh-33248
@snicoll snicoll closed this in e5c505b Jul 21, 2024
@snicoll
Copy link
Member

snicoll commented Jul 21, 2024

Good catch @ngocnhan-tran1996. I've moved the code snippet to an actual class in case this happens again in the future.
@ngocnhan-tran1996
Copy link
Contributor Author

@snicoll

Thanks for your review.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: documentation A documentation task

3 participants

@ngocnhan-tran1996 @snicoll @spring-projects-issues