expand url regex to allow for userinfo #746
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Closes #745
Expands the URL regex used in
validate_download_location
to allow for auserinfo
specifier to appear before the hostname. Previously, a value likegit+ssh://git@git.myproject.org/MyProject.git
would fail validation due to the inclusion of thegit@
portion of the URL.In the URI spec (RFC2396), the
userinfo
portion of the server component is defined as follow:I translated this into the following regex:
and then placed it as an optional prefix to the hostname (with a trailing
@
character)