Skip to content

Conversation

tardyp
Copy link
Contributor

@tardyp tardyp commented Jul 29, 2021

example taken from spdx/spdx-spec#439
coming from ART people

I came into some of the issues of #180 like multiple package support and pkgFilesAnalyzed, so it will probably override it.

example taken from spdx/spdx-spec#439 coming from ART people Signed-off-by: Pierre Tardy <pierre.tardy@renault.com>
@tardyp
Copy link
Contributor Author

tardyp commented Aug 23, 2021

@pombredanne can I get a review/merge for this, please?

lics_from_files = []
if package.are_files_analyzed:
lics_from_files = sorted(package.licenses_from_files, key=lambda lic: lic.identifier)
return OrderedDict([
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we could drop OrderedDict soon now that we support only 3.6+

Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you ++

@pombredanne pombredanne merged commit 21ea183 into spdx:main Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants