Skip to content

Conversation

njv299
Copy link
Contributor

@njv299 njv299 commented Jul 16, 2021

This is a simple attempt to fix this issue:

#182

Essentially, it just removes the check for a Package checksum to be SHA1 since the SPDX spec does not require that.

Signed-off-by: Nathan Voss <nathan@finitestate.io>
tardyp
tardyp previously approved these changes Jul 26, 2021
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ++
Do you mind to add a test with this?

Signed-off-by: Nathan Voss <nathan@finitestate.io>
@njv299 njv299 force-pushed the allow-non-sha1-on-packages branch from 087e23c to da3d5c9 Compare August 12, 2021 16:57
njv299 added 2 commits August 12, 2021 09:58
Signed-off-by: Nathan Voss <nathan@finitestate.io>
@njv299
Copy link
Contributor Author

njv299 commented Aug 12, 2021

@pombredanne I added a test as requested.

Thanks!

Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you ++

@pombredanne
Copy link
Member

Some of the tests on Circle and Appveyor take forever to complete.

@tardyp
Copy link
Contributor

tardyp commented Aug 24, 2021

@pombredanne they don't.. they will never be done, because they are not done for PRs.
you should remove "continuous-integration/appveyor/branch" from the required tests in the protected branch area.
This test is only done after merge.

@pombredanne
Copy link
Member

@tardyp thanks! You rock. I fixed this.

@pombredanne pombredanne merged commit fff191c into spdx:main Aug 24, 2021
@njv299 njv299 deleted the allow-non-sha1-on-packages branch August 25, 2021 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants