Skip to content

Conversation

licquia
Copy link
Collaborator

@licquia licquia commented Jun 4, 2021

Click dropped support for all 2.x versions and all 3.5 or earlier
versions of Python. So, in order to support those versions, we
must tie the click version to click 7.x.

Since we're still actively testing these older Python versions
in CI, this should fix a number of issues in CI.

Fixes #161.

Click dropped support for all 2.x versions and all 3.5 or earlier versions of Python. So, in order to support those versions, we must tie the click version to click 7.x. Since we're still actively testing these older Python versions in CI, this should fix a number of issues in CI. Fixes spdx#161. Signed-off-by: Jeff Licquia <licquia@linuxfoundation.org>
@licquia
Copy link
Collaborator Author

licquia commented Jun 5, 2021

Per comment from @pombredanne in PR #164, it's probably better to just drop testing for 2.7, 3.4, and 3.5. Adjusted accordingly.

Signed-off-by: Jeff Licquia <licquia@linuxfoundation.org>
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@pombredanne
Copy link
Member

I am merging anyway as this PR is to fix the CI.
@licquia FYI I enabled the DCO bot on this repo.

@pombredanne pombredanne merged commit f809cb5 into spdx:master Jun 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants