Enhancement/adding ability to reset idle #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Hello,
I was using your library with great success in the browser for the application I was working on. However, when it came to unit testing the app with the timer, I had some issues. There was no way for the timer to reset ( that I could find ). Sending events to the DOM that would reset in a normal browser had no effect in the JSDom environment.
Perhaps I could have been doing it wrong, but I found success by adding a method to the gloval plugin, extending
idle-jscapabilities already in place.I added the method, and wrote some documentation for the readme. If this isn't welcomed, or wanted, please disregard. I really like the lib and hope this is useful.