Avoid reading from STDOUT when rewind() fails

[Rafagd]

If rewind silently fails and the return is not checked, it's possible stream_get_contents will hang forever waiting for new input that will never come.

I have tested this on Linux and Linux on WSL and I couldn't reproduce the error, but it happens in our FreeBSD server.
I'm not sure if it's a FreeBSD quirk or something weird with our configs, but it seems like it's a sensible change to avoid reading the stream if it couldn't be rewound.

This is related to the issue: #6401

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.32%. Comparing base (c6b89b6) to head (5f7b29c).
⚠️ Report is 1 commits behind head on 11.5.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@ Coverage Diff @@ ## 11.5 #6402 +/- ## ========================================= Coverage 95.32% 95.32% Complexity 7148 7148 ========================================= Files 737 737 Lines 21827 21827 ========================================= Hits 20807 20807 Misses 1020 1020 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[devnexen]

I was able to reproduce and indeed the php_stream_read part hangs. The fix looks right to me.

[sebastianbergmann]

Thank you, David, for taking the time to look into this!

[Rafagd]

Thanks for having a look at it @devnexen . Was I right that it's a FreeBSD thing?

Also thanks @sebastianbergmann for taking some time for this one too.

[devnexen]

Thanks for having a look at it @devnexen . Was I right that it's a FreeBSD thing?

It might or it might not. There are other platforms out there such as netbsd/openbsd ... solaris/illumos.