Improve performance of NamePrettifier::prettifyTestMethodName() #5748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mfn reviewed Mar 13, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## 10.5 #5748 +/- ## ========================================= Coverage 90.08% 90.09% - Complexity 6437 6438 +1 ========================================= Files 680 680 Lines 19535 19536 +1 ========================================= + Hits 17599 17601 +2 + Misses 1936 1935 -1 ☔ View full report in Codecov by Sentry. |
sebastianbergmann added feature/testdox sebastianbergmann changed the title NamePrettifier->prettifyTestMethodName()NamePrettifier::prettifyTestMethodName() Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
the function call is showing up in blackfire profiles of
blackfire run php ./phpunit --testsuite unitdiff