Skip to content

Make ArraySeq extend IndexedSeqOptimized #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 12, 2023
Merged

Make ArraySeq extend IndexedSeqOptimized #581

merged 3 commits into from
Apr 12, 2023

Conversation

RustedBones
Copy link
Contributor

Make ArraySeq[T] extends IndexedSeqOptimized[T, ArraySeq[T]] so that operation expecting CanBuildFrom[ArraySeq[_], T, ArraySeq[T]] return specialized ArraySeq[T] instead of IndexedSeq[T].

Without this, the following can't compile

val x = ArraySeq(1, 2) val y = ArraySeq(3, 4) val z: ArraySeq[Int] = x ++ y
@SethTisue
Copy link
Member

@scala/collections ?
@RustedBones
Copy link
Contributor Author

Any news on this one ?
@SethTisue
Copy link
Member

@lrytz @julienrf maybe one of you would like to review this...?
julienrf
julienrf approved these changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@julienrf julienrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good to me, and it should also bring performance improvements!
@lrytz lrytz force-pushed the typed-can-build-from branch 2 times, most recently from 15f612a to 3c71917 Compare April 12, 2023 09:27
lrytz
lrytz approved these changes Apr 12, 2023
View reviewed changes
Copy link
Member

@lrytz lrytz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you @RustedBones
@lrytz lrytz force-pushed the typed-can-build-from branch from 3c71917 to 9d64f5c Compare April 12, 2023 09:33
@lrytz lrytz merged commit cd00be9 into scala:main Apr 12, 2023
@RustedBones RustedBones deleted the typed-can-build-from branch April 12, 2023 12:06
@SethTisue SethTisue changed the title Make ArraySeq extends IndexedSeqOptimized Make ArraySeq extend IndexedSeqOptimized Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@RustedBones @SethTisue @lrytz @julienrf