On FreeBSD, set the ELF symbol version for readdir_r #4694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
rustbot added O-unix S-waiting-on-review stable-nominated 
This function will probably be removed in FreeBSD 16. But the old symbol will remain, for backwards-compatibility. Set the symbol version now, so that the current version of libc will still be able to compile on future versions of FreeBSD.
tgross35 force-pushed the readdir_r@FBSD_1.5 branch from 7793f16 to 721a03a Compare 
tgross35 approved these changes Sep 22, 2025
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Sep 23, 2025
This function will probably be removed in FreeBSD 16. But the old symbol will remain, for backwards-compatibility. Set the symbol version now, so that the current version of libc will still be able to compile on future versions of FreeBSD. (backport <rust-lang#4694>) (cherry picked from commit 3908285)
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Sep 23, 2025
This function will probably be removed in FreeBSD 16. But the old symbol will remain, for backwards-compatibility. Set the symbol version now, so that the current version of libc will still be able to compile on future versions of FreeBSD. (backport <rust-lang#4694>) (cherry picked from commit 3908285)
Merged
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Sep 23, 2025
This function will probably be removed in FreeBSD 16. But the old symbol will remain, for backwards-compatibility. Set the symbol version now, so that the current version of libc will still be able to compile on future versions of FreeBSD. (backport <rust-lang#4694>) (cherry picked from commit 3908285)
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Sep 23, 2025
This function will probably be removed in FreeBSD 16. But the old symbol will remain, for backwards-compatibility. Set the symbol version now, so that the current version of libc will still be able to compile on future versions of FreeBSD. (backport <rust-lang#4694>) (cherry picked from commit 3908285)
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Sep 23, 2025
This function will probably be removed in FreeBSD 16. But the old symbol will remain, for backwards-compatibility. Set the symbol version now, so that the current version of libc will still be able to compile on future versions of FreeBSD. (backport <rust-lang#4694>) (cherry picked from commit 3908285)
tgross35 added stable-applied Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This function will probably be removed in FreeBSD 16. But the old symbol will remain, for backwards-compatibility. Set the symbol version now, so that the current version of libc will still be able to compile on future versions of FreeBSD.
If and when the
readdir_rfunction does get removed, libc's CI will start to fail. But the crate itself will continue to build, thanks to this PR.Sources
https://github.com/freebsd/freebsd-src/blob/455426da078cbbea8160bf4232b3fd1ae56e2ff5/lib/libc/gen/Symbol.map#L421
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI
@rustbot label +stable-nominated