Skip to content

Enable strftime, mkostemp[s] on Redox #4629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 13, 2025
Merged

Enable strftime, mkostemp[s] on Redox #4629

merged 1 commit into from
Aug 13, 2025

Conversation

@joshuamegnauth54
Copy link
Contributor

@joshuamegnauth54 joshuamegnauth54 commented Aug 10, 2025 •
edited
Loading

Description

I exported a few functions that Redox's relibc supports (see the sources section). Nothing fancy.

Sources

Here are links to where the functions are implemented in relibc:

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI
@joshuamegnauth54
Enable strftime, mkostemp[s] on Redox
f3b852f 
Redox's relibc supports: * mkostemp * mkostemps * strftime
tgross35
tgross35 approved these changes Aug 11, 2025
View reviewed changes
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, thanks for providing links. Any reason it's marked as a draft?
@joshuamegnauth54
Copy link
Contributor Author

I wanted to get confirmation from someone from Redox first. Also, I didn't run the tests yet due to a busy day (I hope to run them soon though!).
@tgross35
Copy link
Contributor

Makes sense, cc @jackpot51 for the redox portion.
jackpot51
jackpot51 approved these changes Aug 11, 2025
View reviewed changes
Copy link
Contributor

@jackpot51 jackpot51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me
@joshuamegnauth54 joshuamegnauth54 marked this pull request as ready for review August 13, 2025 04:32
@tgross35 tgross35 added this pull request to the merge queue Aug 13, 2025
@tgross35
Copy link
Contributor

Thanks for the PR, and for the review!
@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Aug 13, 2025
Merged via the queue into rust-lang:main with commit 8380bad Aug 13, 2025
48 of 52 checks passed
@joshuamegnauth54 joshuamegnauth54 deleted the missing-redox-fns branch August 19, 2025 23:29
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Sep 19, 2025
@joshuamegnauth54 @tgross35
Enable strftime, mkostemp[s] on Redox
7899ad2 
Redox's relibc supports: * mkostemp * mkostemps * strftime (backport <rust-lang#4629>) (cherry picked from commit 8380bad)
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Sep 19, 2025
@joshuamegnauth54 @tgross35
Enable strftime, mkostemp[s] on Redox
db85a64 
Redox's relibc supports: * mkostemp * mkostemps * strftime (backport <rust-lang#4629>) (cherry picked from commit 8380bad)
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Sep 19, 2025
@joshuamegnauth54 @tgross35
Enable strftime, mkostemp[s] on Redox
e79dc9e 
Redox's relibc supports: * mkostemp * mkostemps * strftime (backport <rust-lang#4629>) (cherry picked from commit 8380bad)
@tgross35 tgross35 mentioned this pull request Sep 19, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Sep 19, 2025
@joshuamegnauth54 @tgross35
Enable strftime, mkostemp[s] on Redox
76c7669 
Redox's relibc supports: * mkostemp * mkostemps * strftime (backport <#4629>) (cherry picked from commit 8380bad)
github-merge-queue bot pushed a commit that referenced this pull request Sep 19, 2025
@joshuamegnauth54 @tgross35
Enable strftime, mkostemp[s] on Redox
80b11d6 
Redox's relibc supports: * mkostemp * mkostemps * strftime (backport <#4629>) (cherry picked from commit 8380bad)
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

O-redox O-unix stable-applied This PR has been cherry-picked to libc's stable release branch

4 participants

@joshuamegnauth54 @tgross35 @jackpot51 @rustbot