Fix: Make warnings(false) actually suppress compiler warnings #1633
+42 −4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…rnings Previously, calling warnings(false) didn't add any flags, so the compiler still showed warnings. Now it actively adds -w (GCC/Clang) or -W0 (MSVC) to properly disable them. Changes: - Added warnings_suppression_flags() method to ToolFamily - Modified warning logic to handle warnings(false) case explicitly - Added tests for GNU and MSVC warning suppression
naoNao89 force-pushed the fix/warnings-false-suppression branch from f1981c4 to 323e896 Compare 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #283
warnings(false)now actually suppresses compiler warnings instead of doing nothing.Previously, calling
warnings(false)didn't add any flags, so the compiler still showed warnings.Now it actively adds
-w(GCC/Clang) or-W0(MSVC) to properly disable them. No more needing the.flag("-Wno-all")workaround